-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
166152324 Allow users to select language for Ingredients and exercise #26
166152324 Allow users to select language for Ingredients and exercise #26
Conversation
… exercises - Add support for drop down lists for languages on both exercises and ingredients overview page - Update views to allow change of language when filtering through the languages - Add tests for the function [delivers #166152324]
b4b6518
to
8d0ead9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works as expected,
I can successfully view ingredients and exercises in different languages of my choosing & this helps me see items that were present but hidden. Good job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job. The filtering of exercises and the filtering of ingredients by language works seamlessly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected.
I think for the button text "select" is better compared to ''Choose". Consider this with some input from the team
Awesome work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works according to the task description
Title
Allow users to choose which languages they want to view exercises and ingredients in.
Description
Users should be able to select a language from a dropdown menu with which they would be able to view ingredients and exercises.
To test this
story/166152324-make-translations-easier
python manage.py runserver
3 Navigate to
/en/exercise/overview
and/en/nutrition/ingredient/overview/
4 Select language from the dropdown menu on the right
Type of change
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update
Checklist:
PT stories
#166152324