Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

166152324 Allow users to select language for Ingredients and exercise #26

Merged
merged 1 commit into from
Jun 19, 2019

Conversation

Kimaiyo077
Copy link
Contributor

@Kimaiyo077 Kimaiyo077 commented Jun 18, 2019

Title

Allow users to choose which languages they want to view exercises and ingredients in.

Description

Users should be able to select a language from a dropdown menu with which they would be able to view ingredients and exercises.

To test this

  1. Check out the branch story/166152324-make-translations-easier
  2. Run python manage.py runserver
    3 Navigate to /en/exercise/overview and /en/nutrition/ingredient/overview/
    4 Select language from the dropdown menu on the right

Screenshot 2019-06-18 at 14 13 38

Screenshot 2019-06-18 at 14 13 56

Type of change

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

  • This change requires a documentation update

Checklist:

  • Add support for drop-down lists for languages on both exercises and ingredients overview page
  • Update views to allow change of language when filtering through the languages

PT stories

#166152324

@Kimaiyo077 Kimaiyo077 added the 🚧 Work in Progress When a PR is not yet ready to be reviewed label Jun 18, 2019
… exercises

- Add support for drop down lists for languages on both exercises and ingredients overview page
- Update views to allow change of language when filtering through the languages
- Add tests for the function

[delivers #166152324]
@Kimaiyo077 Kimaiyo077 force-pushed the story/166152324-make-translations-easier branch from b4b6518 to 8d0ead9 Compare June 19, 2019 11:18
@Kimaiyo077 Kimaiyo077 changed the title 166152324 Make translations easier for ingredients and exercises 166152324 Allow users to select language for Ingredients and exercise Jun 19, 2019
@Kimaiyo077 Kimaiyo077 added 👍 ready Ready for review and removed 🚧 Work in Progress When a PR is not yet ready to be reviewed labels Jun 19, 2019
Copy link
Contributor

@Tevinthuku Tevinthuku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as expected,
I can successfully view ingredients and exercises in different languages of my choosing & this helps me see items that were present but hidden. Good job

Copy link
Contributor

@justMuriithi justMuriithi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. The filtering of exercises and the filtering of ingredients by language works seamlessly.

Copy link
Contributor

@martinMutuma martinMutuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected.
I think for the button text "select" is better compared to ''Choose". Consider this with some input from the team
Awesome work.

Copy link
Contributor

@michael-basweti michael-basweti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works according to the task description

@michael-basweti michael-basweti merged commit 2536840 into develop Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👍 ready Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants