166152322 Add support for drop sets #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 19, 2019
misocho
force-pushed
the
story/166152322-drop-sets
branch
from
c39c408
to
4cad1f2
Compare
houndci-bot
reviewed
Jun 19, 2019
misocho
force-pushed
the
story/166152322-drop-sets
branch
2 times, most recently
from
7464cbf
to
ae57e1d
Compare
misocho
added
👍 ready
misocho
requested review from
bencyn,
justMuriithi,
martinMutuma,
Tevinthuku and
Kimaiyo077
martinMutuma
approved these changes
Jun 19, 2019
justMuriithi
suggested changes
Jun 19, 2019
misocho
force-pushed
the
story/166152322-drop-sets
branch
from
ae57e1d
to
83287c7
Compare
|
@justMuriithi, Thanks for the d=feedback. I've implemented it |
Tevinthuku
approved these changes
Jun 19, 2019
There was a problem hiding this comment.
Awesome work, this works as expected and also marking the reps fields as optional as requested by @justMuriithi.
It's convenient how I can just specify a percentage and an initial weight and have it calculate the exact weight I need to drop to in the next repetition
justMuriithi
approved these changes
Jun 19, 2019
Kimaiyo077
approved these changes
Jun 20, 2019
There was a problem hiding this comment.
Excellent work @misocho. The feature works as expected and thumbs up for implementing the feedback given.
misocho
force-pushed
the
story/166152322-drop-sets
branch
from
83287c7
to
04f2f09
Compare
houndci-bot
reviewed
Jun 20, 2019
misocho
force-pushed
the
story/166152322-drop-sets
branch
from
04f2f09
to
7747089
Compare
- Add dropset template view - Implement repetition dropset - Implement weight dropset - Calculate dropset - Add page reload [Delivers #166152322]
misocho
force-pushed
the
story/166152322-drop-sets
branch
from
7747089
to
2fc9b4e
Compare
bencyn
approved these changes
Jun 20, 2019
michael-basweti
approved these changes
Jun 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Add support for drop sets
Description
Drop sets are essentially a technique where you perform an exercise and then drop (reduce) the weight and continue for more reps until you reach failure.
Type of change
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update
How Has This Been Tested?
Acceptance Criteria:
Checklist:
PT stories
#166152322