Update tests to fix problem with negative integers when using older v…

…ersions of protoc
andersfugmann · Apr 25, 2024 · 637f0cc · 637f0cc
1 parent d314a9a
commit 637f0cc
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/test/enum_test.ml b/test/enum_test.ml
@@ -27,6 +27,6 @@ let%expect_test _ =
 let%expect_test _ =
   let module T = Enum.Negative in
   let t = T.Enum.A3 in
-  Test_lib.test_encode ~proto_file (module T) t;
+  Test_lib.test_encode ~skip_json:true ~proto_file (module T) t;
   [%expect {|
     e: A3 |}]
diff --git a/test/int_types_test.ml b/test/int_types_test.ml
@@ -7,7 +7,7 @@ let test_signed (type t) ~(create : int -> t) (module T : Test_lib.T with type t
   Printf.printf "Test %s\n%!" (T.name ());
   let values = [-1073741823; -2; -1; 0; 1; 2; 1073741823] in
   List.iter
-    ~f:(fun v -> Test_lib.test_encode ~proto_file (module T) (create v))
+    ~f:(fun v -> Test_lib.test_encode ~skip_json:true ~proto_file (module T) (create v))
     values
 
 let test_unsigned (type t) ~(create : int -> t) (module T : Test_lib.T with type t = t) =

diff --git a/test/test_lib.ml b/test/test_lib.ml
@@ -130,8 +130,8 @@ let test_json ~debug ~proto_file (type t) (module M : T with type t = t) (t: t)
         |> Reader.create
         |> M.from_proto_exn
       in
-      if t <> t' then Printf.printf "Deserialized json does not match.\n";
-      if t <> t'' then Printf.printf "Deserialized generated json does not match\n";
+      if not (M.equal t t') then Printf.printf "Deserialized json does not match.\n";
+      if not (M.equal t t'') then Printf.printf "Deserialized generated json does not match\n";
       if (not (Yojson.Basic.equal json' json)) then
         Printf.printf "Generated json not equal\n";