Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cgi 7.8 ready #7

Closed
wants to merge 3 commits into from
Closed

Make cgi 7.8 ready #7

wants to merge 3 commits into from

Conversation

jhenahan
Copy link

Builds under the latest platform and 7.8-RC2.

A different approach than the one taken in the other PR.

There may be a more elegant solution, I just followed the
common pattern I've seen in a few other libraries.

The version bump may also be overly aggressive.

Builds under the latest platform and 7.8-RC2.

There's probably a less hack-y way to do this, I just wanted to
make it work.
Builds under the latest platform and 7.8-RC2.

There's probably a less hack-y way to do this, I just followed the
common pattern I've seen in a few other libraries.
@relrod
Copy link

relrod commented Jul 14, 2014

@andersk ping! Can this be merged? Current cgi on hackage does not build on 7.8.3.

@mpickering
Copy link

I tried this patch and the build still failed on MonadCatchIO-mtl.

@cheecheeo
Copy link

@mpickering using "The Glorious Glasgow Haskell Compilation System, version 7.8.3" and running cabal -j install with a fresh cabal sandbox works fine for me. Does it fail on a different version of the compiler?

@mpickering
Copy link

Ok this succeeds in a fresh sandbox but fails with mtl-2.2.1. Sorry for the incorrect report.

Configuring MonadCatchIO-mtl-0.3.0.5...
Building MonadCatchIO-mtl-0.3.0.5...
Preprocessing library MonadCatchIO-mtl-0.3.0.5...
[1 of 1] Compiling Control.Monad.CatchIO ( Control/Monad/CatchIO.hs, dist/dist-sandbox-b6663262/build/Control/Monad/CatchIO.o )

Control/Monad/CatchIO.hs:55:15: Not in scope: ‘E.block’

Control/Monad/CatchIO.hs:56:15: Not in scope: ‘E.unblock’
Failed to install MonadCatchIO-mtl-0.3.0.5

@cheecheeo
Copy link

@mpickering Is failing to build with mtl-2.2.1 a blocker for haskell-cgi? See also: #1 I'm pretty sure the intent of this ticket is just to get haskell-cgi working with GHC 7.8

@cheecheeo
Copy link

cgi successfully builds with mtl-2.2.1 with the following cabal command:
cabal -j install --constraint=mtl==2.2.1 --constraint=MonadCatchIO-mtl==0.3.1.0 --allow-newer=MonadCatchIO-transformers I'll reach out to the MonadCatchIO-mtl maintainer to up the bounds of the package.

@jhenahan
Copy link
Author

@andersk ping!

@cheecheeo
Copy link

For those following this thread. I'm working with @cartazio to push a new version to hackage here: cheecheeo/haskell-cgi#1 If you'd like to comment or follow along.

@jhenahan jhenahan closed this Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants