Cantidad de embarazos #1746
Merged
Cantidad de embarazos #1746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
MarianoCampetella
force-pushed
the
PER-77
branch
from
6ef9d84
to
b457bed
Compare
plammel
reviewed
Aug 26, 2022
Comment on lines
72
to
75
| const arrayPos = prestacion.ejecucion.registros.findIndex(reg => reg.concepto.conceptId === '364323006'); | ||
| if (arrayPos !== -1) { | ||
| carnet['cantidadEmbarazos'] = prestacion.ejecucion.registros[arrayPos].valor; | ||
| } |
There was a problem hiding this comment.
Suggested change
| const arrayPos = prestacion.ejecucion.registros.findIndex(reg => reg.concepto.conceptId === '364323006'); | |
| if (arrayPos !== -1) { | |
| carnet['cantidadEmbarazos'] = prestacion.ejecucion.registros[arrayPos].valor; | |
| } | |
| const registro = prestacion.ejecucion.registros.find(reg => reg.concepto.conceptId === '364323006'); | |
| if (registro) { | |
| carnet['cantidadEmbarazos'] = registro.valor; | |
| } |
There was a problem hiding this comment.
Corregido!
Comment on lines
170
to
173
| if (embarazo.conceptId === '127374005') { | ||
| const index = prestacion.ejecucion.registros.findIndex(reg => reg.concepto.conceptId === '364323006'); | ||
| query['cantidadEmbarazos'] = { $eq: prestacion.ejecucion.registros[index].valor }; | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (embarazo.conceptId === '127374005') { | |
| const index = prestacion.ejecucion.registros.findIndex(reg => reg.concepto.conceptId === '364323006'); | |
| query['cantidadEmbarazos'] = { $eq: prestacion.ejecucion.registros[index].valor }; | |
| } | |
| if (embarazo.conceptId === '127374005') { | |
| const registro = prestacion.ejecucion.registros.find(reg => reg.concepto.conceptId === '364323006'); | |
| query['cantidadEmbarazos'] = { $eq: registro.valor }; | |
| } |
There was a problem hiding this comment.
Corregido!
| }; | ||
| const arrayPos = prestacion.ejecucion.registros.findIndex(reg => reg.concepto.conceptId === '364323006'); |
There was a problem hiding this comment.
Los concept ids está bueno parametrizarlos para no tenerlos hardcodeados en varios lugares
There was a problem hiding this comment.
Como por ahora no tenemos forma de traerlo de la BD, se piensa hacer una restructuración de ese módulo respecto al uso de los conceptId en una nueva tarea que se dejara en backlog
MarianoCampetella
force-pushed
the
PER-77
branch
from
b457bed
to
a955774
Compare
MCele
approved these changes
Nov 22, 2022
silviroa
approved these changes
Nov 22, 2022
liquid36
pushed a commit
that referenced
this pull request
May 17, 2023
# [5.93.0](v5.92.0...v5.93.0) (2023-05-17) ### Bug Fixes * **CDA:** se corrige error al generar CDA de paciente con sexo otro ([#1791](#1791)) ([df0541f](df0541f)) * **chore:** parser ([6774213](6774213)) * **chore:** parser ([#1720](#1720)) ([9f4844f](9f4844f)) * **CIT:** Cannot set headers.. ([#1727](#1727)) ([61db2ad](61db2ad)) * **huds:** evita buscar firma si no valido un profesional ([#1765](#1765)) ([3d3e3aa](3d3e3aa)) * **INT:** Se cambia filtros en el GET de prestaciones de internacion ([#1747](#1747)) ([7b6db99](7b6db99)) * **JOB:** Se Agrega fecha de emision de resultado al cargar la determinación ([#1740](#1740)) ([7072191](7072191)) * **mail:** corrige error envío mail ([#1805](#1805)) ([4706a53](4706a53)) * **mpi:** event paciente ([#1724](#1724)) ([d045453](d045453)) * **mpi:** fix registro extranjeros ([#1750](#1750)) ([3e2cc2f](3e2cc2f)) * **MPI:** Cambia el control de parametros para busqueda de pacientes ([#1762](#1762)) ([4a394aa](4a394aa)) * **MPI:** Se quita acceso a foto del paciente. Agrega control de parametros vacios ([#1761](#1761)) ([d616c68](d616c68)) ### Features * **CIT-185:** Guardar motivo de suspension de agenda ([#1743](#1743)) ([d3ad509](d3ad509)) * **CIT-199:** Agregar filtro de prestacion en el sidebar ([#1771](#1771)) ([f93f3a1](f93f3a1)) * **GDU:** se agrega el atributo lastLogin ([#1778](#1778)) ([2788407](2788407)) * **GDU-50:** eliminar permiso del punto de inicio en internacion ([#1745](#1745)) ([7836fad](7836fad)) * **HUDS:** Agregar filtro de descargas pendientes ([#1719](#1719)) ([d7b1acb](d7b1acb)) * **in:** nuevo event para eventos nuevos en ejecucion ([#1772](#1772)) ([6e08158](6e08158)) * **in:** se agrega extra 'desbloqueo' a esquema de cama-estados ([#1779](#1779)) ([081898b](081898b)) * **IN:** estado observacion ([#1734](#1734)) ([5b2496b](5b2496b)) * **IN:** motivo suspension indicacion ([#1716](#1716)) ([d5dc8b4](d5dc8b4)) * **IN-499:** registro de estados dentro de una cama ([#1768](#1768)) ([3c8eae5](3c8eae5)) * **INT:** pasar a internacion no censable ([#1702](#1702)) ([1b68c60](1b68c60)) * **MAT:** quitar validacion de nro de tramite ([#1692](#1692)) ([f66f34e](f66f34e)) * **MISC-266:** refactor de los filtros ([#1780](#1780)) ([41e1637](41e1637)) * **MOBILE:** agrega descarga de credencial en formato pdf ([#1763](#1763)) ([b420b2d](b420b2d)) * **PER-77:** cantidad de embarazos ([#1746](#1746)) ([1b5aa28](1b5aa28)) * **RUP:** se agrega permiso a link de plantillas ([#1792](#1792)) ([31fca01](31fca01)) * **TOP:** agrega skip y limit listado reglas ([#1756](#1756)) ([85e0e11](85e0e11)) * **TOP:** nueva solicitud con misma fecha que prestacion ([#1775](#1775)) ([9aaef87](9aaef87)) * **TOP-147:** filtros fecha de actualizacion ([#1776](#1776)) ([b9f6e28](b9f6e28))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requerimiento
https://proyectos.andes.gob.ar/browse/PER-77
Funcionalidad desarrollada
UserStories llegó a completarse
Requiere actualizaciones en la base de datos
En la colección elementos rup con este id: ObjectId("5b057eaf623ded31ac70ed94") se agrego dentro de params un booleano
"required:true" para que sea obligatorio el campo de ingresar el numero de embarazos en caso de seleccionar la opción del select "mas de 10 embarazos". Tambien se elimino la variable max que tiene la cantidad maxima de embarazos ya que se lo considera innecesario a la hora de escribir el numero y se modifico la variable min dejandola en 1.