-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT-Modificar esquema especialidad profesionales #1801
base: master
Are you sure you want to change the base?
Conversation
|
||
const actualizar = true; | ||
const diasAño = 365.25; | ||
const añosRevalida = 5 + 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No seria lo mismo poner const añosRevalida = 6 y aclarar en un comentario que son 5 años de vigencia mas 1 de gracia??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Si, serìa lo mismo, pero como son Cinco años lo correcto y pueden tener un año de gracia. Es para indicar eso.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
En todo caso eso se puede especificar mediante un comentario con los // o /* ... */
Por ejemplo: // Los años de vigencia son 5 años mas 1 año de gracia los cual sumados dan 6
scripts/MAT-119.ts
Outdated
|
||
for (const matriculacion of profMatriculacion) { | ||
|
||
if (matriculacion.periodos.length === 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
esto se puede remplazar por if(!matriculacion.periodos.length) { ... }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hecho
scripts/MAT-134.ts
Outdated
function replSpecialChr(texto: string) { | ||
let textoReplace = texto.replace(/\(/g, '.'); | ||
textoReplace = textoReplace.replace(/\)/g, '.'); | ||
return textoReplace; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No entiendo por qué haces dos veces el .replace a la misma cadena de caracteres.
Esto se podría optimizar de la siguiente manera:
function replSpecialChr(texto: string) { return texto.replace(/(/g, '.'); }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No es lo mismo, primero reemplaza '(' y luego ')' por '.' los dos.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
igual esa funciòn se descartò
1f8dd5d
to
b66a2ed
Compare
Requerimiento
https://proyectos.andes.gob.ar/browse/MAT-119
Funcionalidad desarrollada
UserStories llegó a completarse
Requiere actualizaciones en la base de datos