Skip to content

Commit

Permalink
Migrate breakpoints to use the new teardown mechanism
Browse files Browse the repository at this point in the history
  • Loading branch information
andfoy committed Aug 30, 2021
1 parent 17113af commit 91a43c7
Showing 1 changed file with 26 additions and 1 deletion.
27 changes: 26 additions & 1 deletion spyder/plugins/breakpoints/plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@

# Local imports
from spyder.api.plugins import Plugins, SpyderDockablePlugin
from spyder.api.plugin_registration.decorators import on_plugin_available
from spyder.api.plugin_registration.decorators import (
on_plugin_available, on_plugin_teardown)
from spyder.api.translations import get_translation
from spyder.plugins.breakpoints.widgets.main_widget import BreakpointWidget
from spyder.plugins.mainmenu.api import ApplicationMenus
Expand Down Expand Up @@ -140,6 +141,30 @@ def on_main_menu_available(self):
mainmenu.add_item_to_application_menu(
list_action, menu_id=ApplicationMenus.Debug)

@on_plugin_teardown(plugin=Plugins.Editor)
def on_editor_teardown(self):
widget = self.get_widget()
editor = self.get_plugin(Plugins.Editor)
list_action = self.get_action(BreakpointsActions.ListBreakpoints)

editor.breakpoints_saved.disconnect(self.set_data)
widget.sig_clear_all_breakpoints_requested.disconnect(
editor.clear_all_breakpoints)
widget.sig_clear_breakpoint_requested.disconnect(
editor.clear_breakpoint)
widget.sig_edit_goto_requested.disconnect(editor.load)
widget.sig_conditional_breakpoint_requested.disconnect(
editor.set_or_edit_conditional_breakpoint)

editor.pythonfile_dependent_actions.remove(list_action)

@on_plugin_teardown(plugin=Plugins.MainMenu)
def on_main_menu_teardown(self):
mainmenu = self.get_plugin(Plugins.MainMenu)
list_action = self.get_action(BreakpointsActions.ListBreakpoints)
debug_menu = mainmenu.get_application_menu(ApplicationMenus.Debug)
mainmenu.remove_item_from_application_menu(list_action, debug_menu)

# --- Private API
# ------------------------------------------------------------------------
def _load_data(self):
Expand Down

0 comments on commit 91a43c7

Please sign in to comment.