Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for old Delphi? #102

Closed
Alexey-T opened this issue Dec 21, 2019 · 1 comment
Closed

Drop support for old Delphi? #102

Alexey-T opened this issue Dec 21, 2019 · 1 comment

Comments

@Alexey-T
Copy link
Collaborator

{$IFDEF D3} {$DEFINE UseAsserts} {$ENDIF}
{$IFDEF FPC} {$DEFINE UseAsserts} {$ENDIF}
// Define 'use subroutine parameters default values' option (do not edit this definition).
{$IFDEF D4} {$DEFINE DefParam} {$ENDIF}
{$IFDEF FPC} {$DEFINE DefParam} {$ENDIF}
// Define 'OverMeth' options, to use method overloading (do not edit this definitions).
{$IFDEF D5} {$DEFINE OverMeth} {$ENDIF}
{$IFDEF FPC} {$DEFINE OverMeth} {$ENDIF}

it's not good, maybe drop D5 and older? D4 and older? code not nice with ifdefs.

@andgineer
Copy link
Owner

What exactly is the problem?
We have very simple and easy to understand piece of code.

I agree there is little sense to suppost Delphi before 7.
But what's the harm in this code?

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants