Skip to content
This repository has been archived by the owner on Aug 27, 2022. It is now read-only.

Bug: standalone gallery freeze while closing picture #252

Closed
andi34 opened this issue Jun 3, 2021 · 1 comment · Fixed by #253
Closed

Bug: standalone gallery freeze while closing picture #252

andi34 opened this issue Jun 3, 2021 · 1 comment · Fixed by #253
Assignees
Labels
bug Something isn't working

Comments

@andi34
Copy link
Owner

andi34 commented Jun 3, 2021

Open standalone gallery. Click on a thumbnail to see the full-size image. Close the image.
Gallery freezes.

Problem is inside the photoinit.js:

        gallery.listen('destroy', function () {
            rotaryController.focusSet('#gallery');
        });

Rotary controller is not added to standalone gallery yet.
Rotary Controller should be disabled in standalone gallery or only be used on standalone gallery if enabled.

@andi34 andi34 added the bug Something isn't working label Jun 3, 2021
@jacques42
Copy link
Collaborator

PR #253 fixes the crash and fully implements rotary button support - can some pls try it out ?

@andi34 andi34 added the review Changes ready to be tested label Jun 13, 2021
@andi34 andi34 removed the review Changes ready to be tested label Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants