Revised implementation of enhancement: add temp reading of fritz box … #11
Conversation
| @plugin.fritzCall("getSwitchEnergy", @config.ain) | ||
| .then (energy) => | ||
| @_setEnergy(Math.round(energy / 100.0) / 10.0) | ||
| .then (state) => |
There was a problem hiding this comment.
why is this updated/ outdented now?
There was a problem hiding this comment.
Sorry, my IDE (IDEA) just did this. It should not have any impact as the line is part of a chained call. Feel free to recover the original ident. Note however, that the following two then() class aren't indented on master, either! See https://github.com/andig/pimatic-fritz/blob/master/fritz.coffee#L156 and follwing three lines! So, indentation on master varies.
|
Are you confident now that this works for everybody? |
|
I have tested both update modes thoroughly. Indentation changes have no impact on semantics (see comments on diff). Code changes of PR#10 are included in the current PR. |
|
Could you move the PR10 changes to smartfritz? As it helps abstacting the basic fb api I believe thats were it belongs. Fine to merge then. As for indentation I prefer it unchanged if code is not touched but I realize that IDEs may have differing options. |
|
@andig happy to do that eventually, but I don't have much time right now. So, it'll be great if you can accept the PR as is for now. Regarding smartfritz I am wondering whether or not @nischelwitzer is still maintaining smartfritz. Did you consider contributing your code changes back to the original repo? |
Tried to, but never got a response: nischelwitzer/smartfritz#1. As smartfritz-promise has a different api it doesn't make much sense anyway.
Same for me... Please move the one function to https://github.com/andig/smartfritz |
|
ping @mwittig |
|
Ah, ok. Sorry for not looking into this any earlier. Hope, I find some time to get this done next week. |
|
I've added a |
…#2, includes fixes for: No values anymore after update #7