Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not read full data page when using rowOffset #48

Closed
andipaetzold opened this issue Mar 18, 2021 · 1 comment · Fixed by #177
Closed

Do not read full data page when using rowOffset #48

andipaetzold opened this issue Mar 18, 2021 · 1 comment · Fixed by #177
Labels
enhancement New feature or request released

Comments

@andipaetzold
Copy link
Owner

The library currently always reads all records of a data page and then filters it using Array.slice. This means a performance loss, especially for large table records.

This should be improved such that only data is read that is actually returned.
@andipaetzold andipaetzold mentioned this issue Mar 18, 2021
Merged
@andipaetzold andipaetzold added the enhancement New feature or request label Oct 16, 2021
andipaetzold added a commit that referenced this issue Feb 27, 2022
@andipaetzold
fix: performance of getData with offset/limit
9448a73 
Only the memory of actually requested rows is accessed

close #48
@andipaetzold andipaetzold mentioned this issue Feb 27, 2022
Merged
andipaetzold added a commit that referenced this issue Feb 28, 2022
@andipaetzold
fix: performance of getData with offset/limit (#177)
de6bd37 
Only the memory of actually requested rows is accessed

close #48
github-actions bot pushed a commit that referenced this issue Feb 28, 2022
@semantic-release-bot
chore: 2.2.2 [skip ci]
f2a0d34 
## [2.2.2](v2.2.1...v2.2.2) (2022-02-28)

### Bug Fixes

* performance of getData with offset/limit ([#177](#177)) ([de6bd37](de6bd37)), closes [#48](#48)
@github-actions
Copy link

🎉 This issue has been resolved in version 2.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: performance of getData with offset/limit andipaetzold/mdb-reader
1 participant
@andipaetzold