Add support for submodules and release artifacts #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piegamesde
force-pushed
the
dev
branch
2 times, most recently
from
df15bd1
to
3ffe4ee
Compare
|
I missed this, I'll give it a try some time this week. |
|
Tested it out in fufexan/nix-gaming@0bdbef6 this morning and it seems to work!
It's been a very long week 😅 |
LunNova
approved these changes
Nov 5, 2023
Merged
piegamesde
force-pushed
the
dev
branch
2 times, most recently
from
82e52dc
to
0202964
Compare
|
@piegamesde is there any work left to do on this PR? I am willing to contribute to get this merged sooner. |
|
@fufexan Work is done IIRC, but CI fails for some reason and I cannot reproduce it on my machine. Help appreciated. |
This comment was marked as duplicate.
This comment was marked as duplicate.
andir
reviewed
Jun 14, 2024
andir
reviewed
Jun 14, 2024
|
After a year of struggling with flaky CI and thanks to Andi's help, this is now finally ready! |
This will be required for testing submodules. Also added a couple more hash assertions to some tests.
This ensures that our assumption of GitHub serving all releases as tarballs is always upheld in our tests. We could instead manually specify commit hashes but that is cumbersome.
This adds an `eq` function and a `resolveGitCommit` function. Both come in handy when dealing with tests.
This gives us a better error messages when dealing with failed tests. Also changed the hardcoded commit ids to be resolve during runtime. These shouldn't bitrot.
If we don't do this we can't use the git cli on folders in the Nix store. It'll always barf at us.
andir
reviewed
Jun 25, 2024
andir
reviewed
Jun 25, 2024
piegamesde
force-pushed
the
dev
branch
4 times, most recently
from
cc5d008
to
e6d5507
Compare
andir
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@LunNova please give it a try, I did not manage to write tests for all of the bits
Closes #45
Also contains some refactorings and an implementation of #85