Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YAML modules default for $LoadBlessed was changed to false #133

Merged
merged 1 commit into from
Mar 1, 2020

Conversation

perlpunk
Copy link
Contributor

@perlpunk perlpunk commented Jan 30, 2020

This will fix t/12cpan.t and t/31sessions.t
So I believe #132 is not necessary

I tested with YAML.pm 1.30 and YAML::Syck 1.32

See also https://rt.cpan.org/Ticket/Display.html?id=131602 and https://rt.cpan.org/Ticket/Display.html?id=131615

@jkeenan
Copy link
Contributor

jkeenan commented Jan 30, 2020

This will fix t/12cpan.t and t/31sessions.t
So I believe #132 is not necessary

I tested with YAML.pm 1.30 and YAML::Syck 1.32

See also https://rt.cpan.org/Ticket/Display.html?id=131602 and https://rt.cpan.org/Ticket/Display.html?id=131615

I concur. I'll close my p.r.

Thank you very much.
Jim Keenan

@Tux
Copy link
Contributor

Tux commented Jan 31, 2020

Tested on CentOS 8.1, perl-5.30.1 with YAML::XS and YAML::Syck
Tested on openSUSE TumbleWeed and Leap 15.1, perl-5.30.0 with YAML, YAML::XS and YAML::Syck
All passed!
Thank you @perlpunk

@RogueScholar
Copy link

Tested on (K)Ubuntu 19.10, 5.3.30 kernel, perl-5.28.1 with YAML::XS
Tested on Entware Linux environment running on Netgear R7000 CPE armv7l router, 2.6.36.4 kernel, perl-5.28.1 with YAML and YAML::Syck
All tests successful, successful builds and installs reported via CPAN::Reporter.

If Perl was Pharaoh, then @perlpunk is Moses, saying "Let my CPAN go!" 😜

stigtsp added a commit to stigtsp/nixpkgs that referenced this pull request Feb 18, 2020
ZHF: NixOS#80379
https://hydra.nixos.org/build/112819370
https://hydra.nixos.org/build/112832567

A default has changed in YAML, breaking the latest release of CPAN. This commit
applies a A patch from the PR fixing the problem.

andk/cpanpm#133
veprbl pushed a commit to NixOS/nixpkgs that referenced this pull request Feb 19, 2020
ZHF: #80379
https://hydra.nixos.org/build/112819370
https://hydra.nixos.org/build/112832567

A default has changed in YAML, breaking the latest release of CPAN. This commit
applies a A patch from the PR fixing the problem.

andk/cpanpm#133

(cherry picked from commit 153b0db)
cc #80471
@perlpunk
Copy link
Contributor Author

I added the workaround for perl 5.6.2 where local ... = ... did not work.

I talked to @andk this week and he said would still like to find out if $LoadBlessed is really needed.
I debugged the YAML files used in the tests and the result is that it relies on the following classes to be loaded:
CPAN::URL CPAN::Distribution CPAN::Distrostatus CPAN::DeferredCode

So it seems it's not that easy to get rid of $LoadBlessed

@perlpunk
Copy link
Contributor Author

I created #134 to show how it would look like with YAML::PP::*

@andk andk merged commit 10da44f into andk:master Mar 1, 2020
@andk
Copy link
Owner

andk commented Mar 1, 2020

Thanks, Tina, this helped a lot. Merged now.

@andk
Copy link
Owner

andk commented May 26, 2020

and released as ANDK/CPAN-2.28-TRIAL.tar.gz

@perlpunk perlpunk deleted the fix-31sessions branch December 23, 2023 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants