Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix osx build #139

Closed
wants to merge 2 commits into from
Closed

fix osx build #139

wants to merge 2 commits into from

Conversation

waghanza
Copy link

@waghanza waghanza commented Jun 14, 2016

use objective c++ flag on os x

@andlabs
Copy link
Owner

andlabs commented Jun 14, 2016

The problem with this is that the code is Objective-C, not Objective-C++, and I'd rather not let legal C++ that is illegal C fly through. There has to be a better way... Maybe this can be used as the starting point to a solution, though.

@andlabs
Copy link
Owner

andlabs commented Jun 17, 2016

[09:49:44]  <+ngladitz> then you probably hit https://cmake.org/gitweb?p=cmake.git;a=commit;h=95cdf132489c79e88a10fdf7a7566fa002c7680b
[09:50:16]  <+ngladitz> the fix in that commit is in cmake since v3.1.0

I'll probably just bump the minimum required cmake version to that.

@andlabs andlabs closed this Jun 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants