Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add #uiOpenFolder #190

Closed
wants to merge 9 commits into from
Closed

add #uiOpenFolder #190

wants to merge 9 commits into from

Conversation

ddo
Copy link

@ddo ddo commented Aug 8, 2016

tested on windows mac ubuntu all 64 bit

@ddo
Copy link
Author

ddo commented Aug 8, 2016

working on next PR: #uiSaveFile to add filename as a parameter. so we can set a default file name when saving file.

something like:

uiSaveFile(uiWindow *parent, const char *filename);

what do you think @andlabs

@andlabs
Copy link
Owner

andlabs commented Aug 8, 2016

The dialog system is frozen right now because of highly incompatible modality requirements across OSs. I'm not sure how I'll fix these things, but I'm not going to be adding or changing the standard dialogs until then.

Not sure whether the parameters to uiSaveFile() should be passed directly or through a structure; it depends on how many extra parameters there will be..

@ddo
Copy link
Author

ddo commented Aug 9, 2016

yea since open/save dialog has a lot of options as file types, exist path or not, etc... an option struct that describes in common options between OSs would be ok

@ddo ddo closed this Aug 11, 2016
@armand1m
Copy link

Why it was never merged? It is broken?

@andlabs
Copy link
Owner

andlabs commented Mar 12, 2018

I am not sure what caused them to abandon the CL entirely after I commented about not liking the current dialog system. That being said, not liking the current dialog system is a hindrance to accepting this PR in the first place, but I wouldn't discard it entirely yet.

@andlabs andlabs reopened this Mar 12, 2018
@armand1m
Copy link

armand1m commented Mar 12, 2018

Ok, how can we enable this feature into libui since you're not liking the dialog system as it is? Can we list some tasks that we need to get done for this feature to be implemented?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants