Default font #388
Open
Default font #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mischnic
commented
Jun 4, 2018
| params.DefaultFont = &defaultFont; | ||
| params.Width = p->AreaWidth; | ||
| params.Align = (uiDrawTextAlign) uiComboboxSelected(alignment); | ||
| textLayout = uiDrawNewTextLayout(¶ms); | ||
| uiDrawText(p->Context, textLayout, 0, 0); | ||
| uiDrawFreeTextLayout(textLayout); | ||
|
|
||
| //TODO RENAME? | ||
| uiFreeFontButtonFont(&defaultFont); |
There was a problem hiding this comment.
uiDrawLoadDefaultFont behaves exactly like uiFontButtonFont in that the family needs to be freed, so uiFreeFontButtonFont needs to be called. Should there be a uiFreeDefaultFont function?
andlabs
reviewed
Jun 4, 2018
windows/drawtext.cpp
Outdated
| collection = uiprivLoadFontCollection(); | ||
| family = uiprivFontCollectionFamilyName(collection, dwfamily); | ||
|
|
||
| pixels = GetDeviceCaps(GetDC(NULL), LOGPIXELSY); |
There was a problem hiding this comment.
I'm not sure how correct this part is (will check again later), but I do know you're leaking the result of GetDC(NULL) here.
|
Should this rather be called "system font"? |
|
Either that or DefaultControlFont. |
|
Yes, control sounds appropriate uiLoadControlFont(f);
// or
uiLoadDefaultControlFont(f); |
|
I vote for |
But "draw" is only used in function directly related to area drawing. It's also |
|
@mischnic Right, |
This was referenced Jan 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates #279 to the new api.
Closes #279