Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database attach flow fixed. #131

Merged
merged 1 commit into from Feb 23, 2017
Merged

Conversation

dryganets
Copy link
Contributor

Threading model fixed in order to have all queries executed in the same order. android-native plugin fixed.

@itinance please check this change locally. Your initial change doesn't even compile in android-native. Also it has hard to figure out race condition. So if you have this code running in production I have a bad news for you.

Though I didn't test this as well.
We don't rely on this feature, I just see that it's implemented the way it could cause weird crashes.

…queries executed in the same order. android-native plugin fixed
@itinance
Copy link
Contributor

Wow! Thank you very much! Will test in upcoming days. One of our applications is using ATTACH DATABASE very heavily.
But we never used android-native plugin. Maybe this is the reason that we never noticed issues with that. How did you activate it? What do i have to do to active the native-plugin against the other one.
I was quiet lost those days with the android-part (i am iOS-native-developer and this was my first JAVA-contribution). You can read all this in all these comments on my pull request then ;), also my question why there are two different implementations for android because they are looking quiet the same ^^

@dryganets
Copy link
Contributor Author

dryganets commented Feb 22, 2017

@itinance, one implementation is using system SQLite (android).
And another one uses separately built distribution.
I think it's there historically probably someone experienced some weird issues with system library on Cordova. And it also easier to support your application if you have the same version of SQLite among all android devices and API levels.

to test it just replace android by android-native in settings.gradle of your project.

@dryganets dryganets mentioned this pull request Feb 22, 2017
@andpor andpor merged commit f962d12 into andpor:master Feb 23, 2017
@andpor
Copy link
Owner

andpor commented Feb 23, 2017

@itinance can you double check these changes please?

@itinance
Copy link
Contributor

Confirmed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants