Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage and examples #59

Closed
mefuller opened this issue Sep 14, 2021 · 8 comments
Closed

Usage and examples #59

mefuller opened this issue Sep 14, 2021 · 8 comments

Comments

@mefuller
Copy link
Collaborator

While the manual provides additional information about where to find various main programs, some clarification in the README and comments in the code are strongly needed to make the software more intuitive
(Don't do anything yet, I am still working on the manual)

@mefuller
Copy link
Collaborator Author

The exact meaning/definition of specified h, constant U, and constant Q heat flux is lacking (manual.md).

I am also making a number of edits to spelling and grammar in the manual, which I will submit as a PR.

andr1976 added a commit that referenced this issue Sep 19, 2021
Adding more description to the different heat transfer methods /addressing #59
@andr1976
Copy link
Owner

I have tried to address the meaning of specified h/ const U, constant Q in the manual

@mefuller
Copy link
Collaborator Author

@andr1976 I'll take a look shortly.
Going forward, you may want to make such changes in a separate branch and submit a PR and request me (or another reviewer) so that the differences are obvious and easily commented upon

@andr1976
Copy link
Owner

@mefuller, noted I have created a separate branch https://github.com/andr1976/HydDown/tree/revise-mefuller to address e.g. comments in the code / doc strings etc. I will let you know when to review

@andr1976
Copy link
Owner

@mefuller , I have added you as collaborator in order to be able to invite you to review oull requests. Once you accept I will send a PR for review

andr1976 added a commit that referenced this issue Sep 24, 2021
Revise mefuller, addressing #59  for joss review
@bocklund
Copy link

I also think it would be nice to have something like a quickstart. The instructions in the README and manual to

Run the code as simple as:

python main.py input.yml

does not work if users install from pip instead of from the source tree, since they don't have access to those files. The instructions could be more clear for users who may not be very experienced and don't know where to find the input.yml and main.py files.

@andr1976
Copy link
Owner

@mefuller, let me know if you have more comments I should address or revise the paper/code, also consider closing this issue.

@mefuller
Copy link
Collaborator Author

mefuller commented Oct 1, 2021

Everything looks good

@mefuller mefuller closed this as completed Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants