-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Usage and examples #59
Comments
The exact meaning/definition of specified h, constant U, and constant Q heat flux is lacking (manual.md). I am also making a number of edits to spelling and grammar in the manual, which I will submit as a PR. |
Adding more description to the different heat transfer methods /addressing #59
I have tried to address the meaning of specified h/ const U, constant Q in the manual |
@andr1976 I'll take a look shortly. |
@mefuller, noted I have created a separate branch https://github.com/andr1976/HydDown/tree/revise-mefuller to address e.g. comments in the code / doc strings etc. I will let you know when to review |
@mefuller , I have added you as collaborator in order to be able to invite you to review oull requests. Once you accept I will send a PR for review |
Revise mefuller, addressing #59 for joss review
I also think it would be nice to have something like a quickstart. The instructions in the README and manual to
does not work if users install from pip instead of from the source tree, since they don't have access to those files. The instructions could be more clear for users who may not be very experienced and don't know where to find the |
@mefuller, let me know if you have more comments I should address or revise the paper/code, also consider closing this issue. |
Everything looks good |
While the manual provides additional information about where to find various main programs, some clarification in the README and comments in the code are strongly needed to make the software more intuitive
(Don't do anything yet, I am still working on the manual)
The text was updated successfully, but these errors were encountered: