-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: HydDown: A Python package for calculation of hydrogen (or other gas) pressure vessel filling and discharge #3695
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @mefuller, @bocklund it looks like you're currently assigned to review this paper 🎉. Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Wordcount for |
|
|
@bocklund @mefuller – This is the review thread for the paper. All of our communications will happen here from now on. Please read the "Reviewer instructions & questions" in the first comment above. Both reviewers have checklists at the top of this thread (in that first comment) with the JOSS requirements. As you go over the submission, please check any items that you feel have been satisfied. There are also links to the JOSS reviewer guidelines. The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention #3695 so that a link is created to this thread (and I can keep an eye on what is happening). Please also feel free to comment and ask questions on this thread. In my experience, it is better to post comments/questions/suggestions as you come across them instead of waiting until you've reviewed the entire package. We aim for the review process to be completed within about 4-6 weeks but please make a start well ahead of this as JOSS reviews are by their nature iterative and any early feedback you may be able to provide to the author will be very helpful in meeting this schedule. |
😀@fraukewiese, you probably mean #3695 in
|
Absolutely! #3695, sorry for that, I have corrected it. |
@fraukewiese would you please send me a new invite? I cannot edit the checklist and am getting an error that my invitation expired. Thanks |
OK, the reviewer has been re-invited. @mefuller please accept the invite by clicking this link: https://github.com/openjournals/joss-reviews/invitations |
👋 @mefuller, please update us on how your review is going (this is an automated reminder). |
👋 @bocklund, please update us on how your review is going (this is an automated reminder). |
I've worked through installation, some basic functionality testing (although only superficially), and have thoroughly examined and edited the documentation for the software |
@andr1976: I finished making my first pass on HydDown. I was able to use the Streamlit app online. It looks great. Your documentation looks very detailed and seems to demonstrate the power of HydDown very well. I have opened a few issues to be fixed. Issues blocking my acceptance in the checklist:
Non-blocking issues:
|
@bocklund thanks for commenting, really appreciated. I have updated the setup to include dependencies, fixed input.yml, updated manual/documentation, including guidelines for running tests. I wanted to create a separate PR with you as reviewer, however one of my workflows/actions kept pushing to main (by mistake) when pushing to a seprate branch, so it didn't really work as intended. Now all the fixes have already been merged to main. |
@fraukewiese all the acceptance-blocking issues that I identified have been completed and I'm happy to recommend that HydDown be accepted to JOSS. |
@fraukewiese I am also satisfied with the submission in its present for and recommend acceptance |
@fraukewiese , if/when you accept the paper for publication, I would like to make a new release to the python package index, which includes the improvements made by the reviewers, before the paper is published |
The manuscript has been revised accordingly and the ISBN no has been removed. The latest tagged release https://github.com/andr1976/HydDown/releases/tag/v0.16.2 |
@whedon generate pdf |
@whedon set v0.16.2 as version |
OK. v0.16.2 is the version. |
@andr1976 : The title of the archive should match the title of your paper. Please adapt that, the we can move forward :) |
@whedon set 10.5281/zenodo.5547917 as archive |
OK. 10.5281/zenodo.5547917 is the archive. |
@whedon recommend-accept |
|
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉 openjournals/joss-papers#2646 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#2646, then you can now move forward with accepting the submission by compiling again with the flag
|
Hi @andr1976, I am doing some final checks before accepting. In the third paragraph and in the Acknowledgments section, you have a few instances of consecutive citations. In cases like this, please use the citation format like You also have one or two instances where the Please update these and let me know—thanks! |
@kyleniemeyer thanks for improving the reference style of the paper, much appreciated. I did a final proof-reading myself, but don't have anything to add/correct. Also a big thanks to editor @fraukewiese, reviewers @mefuller and @bocklund 👍 you rock!, and another big thanks to @arfon and entire team behind joss - I think this model for reviewing papers could be adapted by other journals (although single/double blind is a challenge though) - it is very constructive and productive. |
@whedon generate pdf |
@whedon accept deposit=true |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congrats @andr1976 on your article's publication in JOSS! Many thanks to @mefuller and @bocklund for reviewing this, and @fraukewiese for editing. |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @andr1976 (Anders Andreasen)
Repository: https://github.com/andr1976/HydDown
Version: v0.16.2
Editor: @fraukewiese
Reviewer: @mefuller, @bocklund
Archive: 10.5281/zenodo.5547917
Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@mefuller & @bocklund, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @fraukewiese know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Review checklist for @mefuller
✨ Important: Please do not use the Convert to issue functionality when working through this checklist, instead, please open any new issues associated with your review in the software repository associated with the submission. ✨
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @bocklund
✨ Important: Please do not use the Convert to issue functionality when working through this checklist, instead, please open any new issues associated with your review in the software repository associated with the submission. ✨
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
The text was updated successfully, but these errors were encountered: