backport close race condition fix from 1.3 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: package.json
| @@ -139,13 +139,13 @@ FileWriter.prototype = { | |||
| function finish(err) { | |||
| if (guard && global.clearTimeout) clearTimeout(guard); | |||
| guard = null; | |||
| if (fd !== null) fs.close(fd, function(){}); | |||
| if (fd !== null) try { fs.closeSync(fd) } catch (e) { } | |||
There was a problem hiding this comment.
Wouldn't we want to do anything if this failed?
There was a problem hiding this comment.
it doesn't affect correct operation, but we can return the error at least, sure, to let the caller know
that there was a problem. A close error could in theory leak a file descriptor (the possible errors from
the close system call are EBADF, EINTR and EIO)
There was a problem hiding this comment.
the change I pushed showed up in PR #5 ? see https://github.com/andrasq/node-qfputs/pull/5/files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this got fixed during the refactor without it being caught as the source of a race condition.
This is a minimal patch to the 1.2 branch; qfputs-1.3 and 1.4 do not have this issue.