faster gmdate using getSeconds

andrasq · Mar 2, 2020 · 66ee67b · 66ee67b
1 parent c5d5ca5
commit 66ee67b
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/lib/phpdate.js b/lib/phpdate.js
@@ -225,8 +225,11 @@ function configure( config ) {
     GmtDate.prototype.getDay = function GmtDate_getDay() { return this.dt.getUTCDay(); };
     GmtDate.prototype.getDate = function GmtDate_getDate() { return this.dt.getUTCDate(); };
     GmtDate.prototype.getHours = function GmtDate_getHours() { return this.dt.getUTCHours(); };
+    // note: GmtDate is 2x slower than Date, because UTC access methods are 6x slower.
+    // note: if the tz offset coincides in hours, is 10% faster to use getMinutes()
     GmtDate.prototype.getMinutes = function GmtDate_getMinutes() { return this.dt.getUTCMinutes(); };
-    GmtDate.prototype.getSeconds = function GmtDate_getSeconds() { return this.dt.getUTCSeconds(); };
+    // note: all timezones are aligned on minute boundaries, use the faster method
+    GmtDate.prototype.getSeconds = function GmtDate_getSeconds() { return this.dt.getSeconds(); };
 
     var _resultCacheGmt = new ResultCacheRing();
     function gmdate( format, timestamp ) {