PD: fix constructor of TaskTransformedParameters

andre-caldas · Oct 19, 2023 · c85bc2a · c85bc2a
1 parent a9d8074
commit c85bc2a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/src/Mod/PartDesign/Gui/TaskTransformedParameters.cpp b/src/Mod/PartDesign/Gui/TaskTransformedParameters.cpp
@@ -61,12 +61,8 @@ TaskTransformedParameters::TaskTransformedParameters(ViewProviderTransformed *Tr
     , insideMultiTransform(false)
     , blockUpdate(false)
 {
-    selectionMode = none;
-
-    if (TransformedView) {
-        Gui::Document* doc = TransformedView->getDocument();
-        this->attachDocument(doc);
-    }
+    Gui::Document* doc = TransformedView->getDocument();
+    this->attachDocument(doc);
 
     // remember initial transaction ID
     App::GetApplication().getActiveTransaction(&transactionID);
@@ -80,8 +76,6 @@ TaskTransformedParameters::TaskTransformedParameters(TaskMultiTransformParameter
       insideMultiTransform(true),
       blockUpdate(false)
 {
-    // Original feature selection makes no sense inside a MultiTransform
-    selectionMode = none;
 }
 
 TaskTransformedParameters::~TaskTransformedParameters()

diff --git a/src/Mod/PartDesign/Gui/TaskTransformedParameters.h b/src/Mod/PartDesign/Gui/TaskTransformedParameters.h
@@ -225,7 +225,7 @@ protected Q_SLOTS:
     bool enableTransaction = true;
 
     enum selectionModes { none, addFeature, removeFeature, reference };
-    selectionModes selectionMode;
+    selectionModes selectionMode = none;
 
     /// The MultiTransform parent task of this task
     TaskMultiTransformParameters* parentTask;