LDA and QDA: Raise an informative error if the user forgot to set sto…

…re_covariance=True when instantiating the model
andreArtelt · May 8, 2020 · 5619300 · 5619300
1 parent 3e8e3cf
commit 5619300
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/ceml/sklearn/lda.py b/ceml/sklearn/lda.py
@@ -121,6 +121,8 @@ def rebuild_model(self, model):
         """
         if not isinstance(model, LinearDiscriminantAnalysis):
             raise TypeError(f"model has to be an instance of 'sklearn.discriminant_analysis.LinearDiscriminantAnalysis' but not of {type(model)}")
+        if not hasattr(model, "covariance_"):
+            raise AttributeError("You have to set store_covariance=True when instantiating a new sklearn.discriminant_analysis.LinearDiscriminantAnalysis model")
 
         return Lda(model)
 

diff --git a/ceml/sklearn/qda.py b/ceml/sklearn/qda.py
@@ -124,6 +124,8 @@ def rebuild_model(self, model):
         """
         if not isinstance(model, QuadraticDiscriminantAnalysis):
             raise TypeError(f"model has to be an instance of 'sklearn.discriminant_analysis.QuadraticDiscriminantAnalysis' but not of {type(model)}")
+        if not hasattr(model, "covariance_"):
+            raise AttributeError("You have to set store_covariance=True when instantiating a new sklearn.discriminant_analysis.QuadraticDiscriminantAnalysis model")
 
         return Qda(model)