Port to GNOME 45/46 #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lang.bind() has been deprecated for a long time in favor of arrow functions and Function.prototype.bind(), which were standardized in 2015.
Classes were standardized in 2015, and there is no reason to not use them over gjs' custom Lang.Class framework (which has been deprecated).
gjs landed support for TextDecoder/TextEncoder back in 2021. Use those instead of gjs' own ByteArray module.
In GNOME 45, gnome-shell replaced gjs legacy imports system with standard ES modules. As the two import systems cannot generally be mixed, this was a breaking change for extensions. Support newer versions by making the necessary adjustments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In GNOME 45, gnome-shell replaced gjs legacy imports system with
standard ES modules. As the two import systems cannot generally
be mixed, this was a breaking change for extensions.
Support newer versions by making the necessary adjustments.
Includes the cleanups from #8
Closes #6