updated dependencies to stable vers, fixed rx usage #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I loved the tutorial you wrote on Medium/ProAndroidDev regarding this topic.
I've made some changes to how to use RxAndroid with most of its muscles, yes am not disposing the observable after finishing but that's a minor in exchange to the performance boost it got, I've tried before and after changing Rx's code, those are some promising results.
Oh and one more note, while debugging the coroutines of Kotlin I've found the coroutines to be not synced at all, sometime the first int it checks is 10 others are 8 and so on, don't know if I messed something up or what, please let me know what you think, am really enjoying this comparison.