Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing license text for BSD-3-Clause #14

Closed
musicinmybrain opened this issue Mar 14, 2024 · 5 comments
Closed

Missing license text for BSD-3-Clause #14

musicinmybrain opened this issue Mar 14, 2024 · 5 comments
Assignees

Comments

@musicinmybrain
Copy link

musicinmybrain commented Mar 14, 2024

The BSD-3-Clause license states that the copyright notice, list of conditions and disclaimer must be reproduced in all source and binary distributions. Since no license text appears in this repository or in the released crate, it’s not possible to comply with the license stated in Cargo.toml:

license = "BSD-3-Clause"

Please add the necessary license text, preferably in a file called LICENSE.

This should be important for all potential users; it’s important for me so I can add a rust-circular-buffer package to Fedora Linux without guessing at the correct license text.

@andreacorbellini
Copy link
Owner

Hi, thanks for reporting this. This is so embarrassing, I never noticed that I forgot to add the licensing information until now. This is now fixed, and I'll make a minor release soon with these changes.

@andreacorbellini
Copy link
Owner

If you need this to be released by a specific date, let me know and I'll try to accommodate it

@andreacorbellini andreacorbellini self-assigned this Mar 17, 2024
@musicinmybrain
Copy link
Author

Thanks for dealing with this! Missing license text is a surprisingly common oversight.

I don’t have a hard deadline. I’m trying to get the dependencies ready so https://github.com/Netflix/bpftop can be packaged in Fedora. If you’re planning a release in the next few weeks, I think I’ll wait for the release. If it will be longer than that, I’ll probably patch 0.1.5 to include the license text you added so that the bpfman effort can progress.

@andreacorbellini
Copy link
Owner

Version 0.1.7 has been released with (hopefully) correct licensing information. Thanks again for reporting this!

@musicinmybrain
Copy link
Author

Version 0.1.7 has been released with (hopefully) correct licensing information. Thanks again for reporting this!

Thanks, looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants