Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved error messages when no files were restored #327

Closed
wants to merge 2 commits into from

Conversation

lukasvrenner
Copy link
Contributor

@lukasvrenner lukasvrenner commented Jan 14, 2024

Fixes #326
This change makes behavior more transparent when trying to restore a file, but choosing nothing.
It also capitalizes the letter N in trash-empty confirmation, to clarify default behavior.

@lukasvrenner lukasvrenner marked this pull request as draft January 14, 2024 03:05
@lukasvrenner lukasvrenner marked this pull request as ready for review January 14, 2024 03:07
@andreafrancia
Copy link
Owner

Thank you, but it seems that some test are not passing.

andreafrancia added a commit that referenced this pull request Mar 28, 2024
…: "No files were restored" (instead of "Exiting").
@andreafrancia
Copy link
Owner

I've fixed the tests and merged manually with rebase.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hitting return on trash-restore without entering a number results in unclear behavior
2 participants