Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attribute Used Code #1

Closed
dennisweissmann opened this issue Apr 6, 2016 · 2 comments
Closed

Attribute Used Code #1

dennisweissmann opened this issue Apr 6, 2016 · 2 comments

Comments

@dennisweissmann
Copy link

Hey, I just saw a piece of your code that looks very familiar to me ...

https://github.com/andrealufino/Deviice/blob/develop/Pod/Classes/Deviice.swift#L317-L323
https://github.com/dennisweissmann/DeviceKit/blob/master/Source/Device.swift#L177-L185

It would be nice if you would attribute the used code to me, as per the license ;)

Thanks!

-Dennis
@andrealufino
Copy link
Owner

Absolutely right, done!

@dennisweissmann
Copy link
Author

Thanks :)

andrealufino pushed a commit that referenced this issue Oct 29, 2018
@GregOriol
Merge pull request #1 from GregOriol/new-devices
34b4536 
Added a few devices (iPad 6, ...)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrealufino @dennisweissmann