Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadow not animate when PopTip update custom view #199

Closed
N1nomiya opened this issue Nov 26, 2019 · 3 comments
Closed

Shadow not animate when PopTip update custom view #199

N1nomiya opened this issue Nov 26, 2019 · 3 comments

Comments

@N1nomiya
Copy link

N1nomiya commented Nov 26, 2019

I use PopTip with shadow config and show a custom view that would change its frame later.
So I code like:

popTip.shadow = ...
popTip.show(customView: myCustomView, ....)
...
// After myCustomView frame changed
popTip.update(customView: myCustomView)

The problem is PopTip's frame animate correctly but the shadow change immediately. It seems like the override draw() function redraw the shadowPath without animation.

Any ideas about the situation?

@andreamazz
Copy link
Owner

Yeah, good point, the shadow animation should go inside a CoreGraphics animation. Let me check

@andreamazz
Copy link
Owner

Can you check the latest commit on master? It should fix the issue

andreamazz added a commit that referenced this issue Nov 26, 2019
@N1nomiya
Copy link
Author

@andreamazz Cool it works! 🎉 🎉 Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants