-
-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bubble Padding X position #74
Comments
Hi @JaimeYesidLeonParada |
Hi @andreamazz , The idea is easy, add a horizontal offset, if the offset value is positive the bubble needs to move right side and if the value offset is negative the bubble needs to move left side. I will appreciate very much whether you can add this functionality into AMPoptip. |
@andreamazz If do you want I can do a PR with this new functionality. |
Hi, yeah I would appreciate that :) |
@andreamazz excellent. I'll keep you posted. |
@andreamazz I created the PR #75. I call the property as bubbleOffset because is more easy to apply in any direction and don't be restricted to one direction. |
Amazing idea! I would love to use this, @andreamazz can you approve and release a new version with this today? It would be an incredible improvement for all of us that use your framework :D |
Hi @andreamazz , I waiting for the approval to the PR, after this I would like to implement another feature that I had seen in another apps. |
This should be solved now. Closing it, feel free to reopen if you need further assistance. 👍 |
Can you add this to the docs? This is really helpful but I had to come and check the issues page to see if someone else was having this problem and only then did I see that this feature is available. Would have been great to have it in the readme. Great tool by the way! |
Done 👍 |
I Set this property, But The entire view moves, including arrows?
|
@codertian (BTW, you can use backticks if you don't want to prefix
|
Yes thanks! frame.origin.x += bubbleOffset
arrowPosition.x -= bubbleOffset
frame.size = CGSize(width: frame.width + borderWidth * 2, height: frame.height + borderWidth * 2)
return (frame, arrowPosition) |
It is possible to add a padding for the Bubble, position X? In some cases it is necessary move the bubble but not the arrow, for example:
http://www.dreamtemplate.com/dreamcodes/documentation/dc_images/dc-tooltips.jpg
I tested into a fork and looks good.
Thanks
The text was updated successfully, but these errors were encountered: