Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added handlers #142

Merged
merged 5 commits into from
Dec 14, 2017
Merged

Added handlers #142

merged 5 commits into from
Dec 14, 2017

Conversation

felipowsky
Copy link
Contributor

  • Added handler for tap outside and swipe outside
  • Fixed projects' build settings

@andreamazz
Copy link
Owner

Hi @felipowsky
Thanks for this. Any particular reason for renaming cornerRadius to radius?

@felipowsky
Copy link
Contributor Author

Hey @andreamazz,
I have a project with an extension that uses cornerRadius already so I needed to rename it.
I was getting Ambiguous use of 'cornerRadius' when I tried to configured the pop tip.
But I removed this from this PR. It's just the commit that's there.

@andreamazz
Copy link
Owner

Right, I didn't notice the last commit.
Cool, thank you!

@andreamazz andreamazz merged commit 0ceb518 into andreamazz:master Dec 14, 2017
@felipowsky felipowsky deleted the features/handlers branch December 14, 2017 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants