Add ability for a swipe to dismiss pop tip. #42
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION
There is currently an option to dismiss the PopTip when a tap is performed outside of the PopTip. There should also be the option to dismiss the PopTip when a swipe is performed outside of the PopTip. Some PopTips may read "Swipe left to do X", in which case a user performing a swipe should be able to dismiss that PopTip.
PROPOSED CHANGES
Add a
UISwipeGestureRecognizer
that will dismiss the PopTip when a swipe is performed. Due to adding an additionalremoveGesture
I renamed the existing totapRemoveGesture
and addedswipeRemoveGesture
. The swipe direction is defaulted toUISwipeGestureRecognizerDirectionRight
. The direction can also be set if you want to use a different swipe direction.This was kept out of the
commonInit
to avoid accidentally enabling this feature for users.TESTING SUGGESTIONS
self.shouldDismissOnSwipeOutside = YES;
self.swipeRemoveGestureDirection = UISwipeGestureRecognizerDirectionLeft;
.shouldDismissOnSwipeOutside
set toYES
, swipes should not dismiss the PopTip, regardless if the direction is set.Please Review: @andreamazz