Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the background of next view controller turns to be disappeared #18

Closed
S1U opened this issue Nov 23, 2014 · 4 comments
Closed

the background of next view controller turns to be disappeared #18

S1U opened this issue Nov 23, 2014 · 4 comments

Comments

@S1U
Copy link

S1U commented Nov 23, 2014

please refer to this gist, https://gist.github.com/i0sdev/475262e6de902fd9bca8

I found this when after updating to 0.5.3.

The issue is:

i.e., there two view controllers, the first one (table view) is using AMWaveTransition, tap any cells then push to the second view controller, a normal view controller not table view as a simple sample.

set background color for the second one, like gray or any.

run the sample, show the first one view controller correctly, tap and then show the second one, but found the background that's supposed to be gray color disappears instead.

I downgraded it to 0.5.2, it shows as expected, the gray background on the second view controller.

Why?

@S1U S1U changed the title the background of next view controller turns to be disappear the background of next view controller turns to be disappeared Nov 23, 2014
@andreamazz
Copy link
Owner

Hi @i0Sdev
As stated in the readme, the best results are obtained when the view's background is transparent (the library itself assumes that your main background is transparent). It's baffling that version 0.5.2 works, since the only change included in 0.5.3 does not change the background colors. I would suggest to use a view above your VC's main view, and color that one, leaving the main View transparent.

@S1U
Copy link
Author

S1U commented Nov 24, 2014

Hi Andrea,

Here are two videos to show two results:
0.5.3, background color on second view disappeared.​
0.5.3.mov
https://docs.google.com/a/since30.com/file/d/0B_S-FGZcl5cFTmNwM3pGSkxoOVE/edit?usp=drive_web

0.5.2, background color on second view remained.​
0.5.2.mov
https://docs.google.com/a/since30.com/file/d/0B_S-FGZcl5cFMm44NWtxNkVRZjA/edit?usp=drive_web

After going through details, I found some differences 0.5.3 vs 0.5.2. In
0.5.3 vision, it seems like the background color of second view is impacted
by these codes in red rectangles as screenshots attached below. ​
Screen Shot 2014-11-24 at 9.28.48 AM.png
https://docs.google.com/a/since30.com/file/d/0B_S-FGZcl5cFSHczU1dnbjVZN0E/edit?usp=drive_web

if commenting out them, the background color of second view could be
remained also.

The reason that I want to do this is to stay flexibilities of handling the
second view background (or the last view). Maybe, transparent background
during begining couples of view, then comes to the view that has to have a
different background color.

On Sun, Nov 23, 2014 at 11:33 PM, Andrea Mazzini notifications@github.com
wrote:

Hi @i0Sdev https://github.com/i0sdev
As stated in the readme, the best results are obtained when the view's
background is transparent (the library itself assumes that your main
background is transparent). It's baffling that version 0.5.2 works, since
the only change included in 0.5.3 does not change the background colors. I
would suggest to use a view above your VC's main view, and color that one,
leaving the main View transparent.


Reply to this email directly or view it on GitHub
#18 (comment)
.

@andreamazz
Copy link
Owner

I have to check if removing those lines breaks something, since it's code added by a pull request. I'll keep you posted.

@andreamazz
Copy link
Owner

Ok, it should be rather safe to remove those lines. The library shouldn't make that kind of change in the first place. Checkout latest commit for a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants