Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't change anchor links to use the history API if the router doesn't have a match #18

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Don't change anchor links to use the history API if the router doesn't have a match #18

wants to merge 10 commits into from

Commits on Jan 15, 2021

  1. Add support for bypassing router for unhandled links 

    Allow links to be handled by the browser if the router does not support the route.

In the case where you may be proxy-passing from a server-side routing web app to a client-side routing web app, many of the URLs may be unsupported client-side. This allows the links to pass through to the parent router.
    @jbuckner
    jbuckner committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    1def453 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2021

  1. Cleanup AnchorHandler and add tests

    @jbuckner
    jbuckner committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    9f5b467 View commit details
    Browse the repository at this point in the history

  2. Handle metaKey case

    @jbuckner
    jbuckner committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    e9fb5b0 View commit details
    Browse the repository at this point in the history

  3. Update comment

    @jbuckner
    jbuckner committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    ce23bcb View commit details
    Browse the repository at this point in the history

  4. Small reorganize and add comment

    @jbuckner
    jbuckner committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    5477d86 View commit details
    Browse the repository at this point in the history

  5. Add test for catch-all and fix anchor tests

    @jbuckner
    jbuckner committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    957008f View commit details
    Browse the repository at this point in the history

  6. Rename var for brevity

    @jbuckner
    jbuckner committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    578e748 View commit details
    Browse the repository at this point in the history

  7. Update Readme

    @jbuckner
    jbuckner committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    91b76bb View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2021

  1. Fix the anchor event handler removal and add test 

    We weren't properly binding the anchor click handler so it wasn't being unbound properly
    @jbuckner
    jbuckner committed Jan 17, 2021
    Configuration menu
    Copy the full SHA
    6387a45 View commit details
    Browse the repository at this point in the history

  2. Only bind the AnchorHandler in the root router-slot 

    Previously if there were multiple router-slots on-screen, each one would have its own AnchorHandler responding to itself. We only want one at the root.
    @jbuckner
    jbuckner committed Jan 17, 2021
    Configuration menu
    Copy the full SHA
    b8acb91 View commit details
    Browse the repository at this point in the history