Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missed const qualifier in structured binding #116

Closed
Kurkin opened this issue Jan 31, 2019 · 2 comments
Closed

Missed const qualifier in structured binding #116

Kurkin opened this issue Jan 31, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@Kurkin
Copy link

Kurkin commented Jan 31, 2019

#include <string>
#include <unordered_map>

using namespace std;

int main()
{
    unordered_map<string, string> m;
    for (auto & [key, value] : m) {
      
    }
}
#include <string>
#include <unordered_map>

using namespace std;

int main()
{
  unordered_map<std::string, std::string> m = std::unordered_map<std::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::hash<std::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::equal_to<std::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<const std::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::basic_string<char, std::char_traits<char>, std::allocator<char> > > > >();
  {
    std::unordered_map<std::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::hash<std::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::equal_to<std::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<const std::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::basic_string<char, std::char_traits<char>, std::allocator<char> > > > > & __range1 = m;
    std::__detail::_Node_iterator<std::pair<const std::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::basic_string<char, std::char_traits<char>, std::allocator<char> > >, 0, 1> __begin1 = __range1.begin();
    std::__detail::_Node_iterator<std::pair<const std::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::basic_string<char, std::char_traits<char>, std::allocator<char> > >, 0, 1> __end1 = __range1.end();
    
    for( ; std::__detail::operator!=(__begin1, __end1); __begin1.operator++() )
    {
      std::pair<const std::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::basic_string<char, std::char_traits<char>, std::allocator<char> > > & __operator9 = __begin1.operator*();
      std::basic_string<char, std::char_traits<char>, std::allocator<char> >& key = std::get<0ul>(__operator9); // missed const qualifier for key 
      std::basic_string<char, std::char_traits<char>, std::allocator<char> >& value = std::get<1ul>(__operator9);
    }
  }
}
@andreasfertig
Copy link
Owner

Hello @Kurkin,

thanks for reporting that. That is quite a finding. Hard to spot. Thanks! A fix is on its way.

Andreas

andreasfertig added a commit that referenced this issue Feb 1, 2019
Fixed #116: A typedef concealed the const qualifier.
@Kurkin
Copy link
Author

Kurkin commented Feb 1, 2019

Thanks for a quick fix and your awesome tool!

@andreasfertig andreasfertig added the bug Something isn't working label Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants