Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ellipsis missing from template instatiation #128

Closed
knatten opened this issue Feb 22, 2019 · 2 comments
Closed

Ellipsis missing from template instatiation #128

knatten opened this issue Feb 22, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@knatten
Copy link

knatten commented Feb 22, 2019

The instantiation from this code:

template<typename T>
void foo(T, ...) {}

int main(){
   foo(1, 2.);
}

Looks like this:

template<>
void foo<int>(int)
{
}

I think the signature should rather be void foo<int>(int, ...).

Try it on CppInsights.io

@andreasfertig
Copy link
Owner

Hello @knatten,

thanks for reporting that. It is indeed incorrect. A fix is on its way.

Andreas

andreasfertig added a commit that referenced this issue Feb 22, 2019
Fixed #128: Add the missing ellipsis for variadic functions.
@knatten
Copy link
Author

knatten commented Feb 26, 2019

That was quick! <3

@andreasfertig andreasfertig added the bug Something isn't working label Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants