Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolved type names for types defined in class bodies lack their "namespace" #255

Closed
pseyfert opened this issue Oct 15, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@pseyfert
Copy link

comparing this and this example, there is a custom iterator class in both cases.

Abbreviated, in the former, the iterator definition is in another class

struct Iterable {
  struct Iterator {
  };
};

In the latter, the iterator is defined in some namespace

namespace MYNAMESPACE {
  struct Iterator {
  };
}
struct Iterable {
};

In both cases Iterable::begin() returns an Iterator.
Yet, in the cppinsights output, the former iterator appears as Iterator instead of Iterable::Iterator. In the latter case, the leading MYNAMESPACE:: is printed correctly.

I think it would be nice if the leading Iterable:: would also be printed in the former case (for disambiguation, should someone run into a case where that's necessary), and such that the printout of cppinsights is valid code.

@andreasfertig
Copy link
Owner

Hello @pseyfert,

thank you for reporting this. I'll look into it.

Andreas

@andreasfertig andreasfertig added the enhancement New feature or request label Oct 16, 2019
andreasfertig added a commit that referenced this issue Nov 12, 2019
Due to another issue (#255) the result of this issue does not compile.
This will be fixed with #255.
andreasfertig added a commit that referenced this issue Nov 17, 2019
andreasfertig added a commit that referenced this issue Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants