-
-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
insights crashed on some invalid inputs #51
Comments
Hello, that's interesting. While I see the crash online, I cannot confirm it on my machine. I need to have a deeper look into it. Although, invalid code will not give a good result so its not on top of my priority list. |
Your local machine is on OS X, right? My is on linux and I can see a crash locally. Latest llvm+clang built with gcc-8.1.0. |
Thanks for your spec. It's correct I use OS X. I will fire up a docker container and see what's happening there. There is a chance that it is a bug which is also reachable in a different (compiling) context. |
A missing brace in main leads insights to a crash. While the program is invalid, the reason for the crash was a nullptr in FindDeclRef which potentially can occur with valid code as well. The fix handles the case that stmt is a nullptr.
A missing brace in main leads insights to a crash. While the program is invalid, the reason for the crash was a nullptr in FindDeclRef which potentially can occur with valid code as well. The fix handles the case that stmt is a nullptr.
Fixed issue #51: Crash of insights with invalid code.
Crashed on the following piece of code:
Output is:
Without line
there is no crash, just errors reported.
The text was updated successfully, but these errors were encountered: