Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coroutines TS #92

Closed
Trass3r opened this issue Nov 13, 2018 · 10 comments
Closed

coroutines TS #92

Trass3r opened this issue Nov 13, 2018 · 10 comments
Labels
enhancement New feature or request WIP Work in progress

Comments

@Trass3r
Copy link

Trass3r commented Nov 13, 2018

Would be useful to see the implemented state machine if that's possible.
https://godbolt.org/z/q6rOaN

@andreasfertig
Copy link
Owner

Hello Trass3r,

I agree. Funny thing, just yesterday I thought about this. I will have a look and see what I can do here.

@andreasfertig andreasfertig added the enhancement New feature or request label Nov 30, 2018
@Trass3r
Copy link
Author

Trass3r commented Dec 1, 2018

@stale
Copy link

stale bot commented Mar 25, 2019

Thanks for contributing to this issue. As it has been 60 days since the last activity waiting for a followup. This issue will be automatically closed in 7 days, if no further activity occurs. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If that's not the case, please respond before the issue is closed. We'll gladly take a look again! In any case, thank you for your contributions!

@stale stale bot added the stale No activity label Mar 25, 2019
@andreasfertig andreasfertig removed the stale No activity label Mar 25, 2019
@andreasfertig
Copy link
Owner

Sorry, I'm testing stale bot and it does exactly the opposite of what I want. This issue will remain open.

@andreasfertig andreasfertig added the WIP Work in progress label Mar 25, 2019
@grishavanika
Copy link
Contributor

Hi. @andreasfertig :)

Is there any progress with this ? Is it possible to contribute ? (nothing to show yet, just asking)

@andreasfertig
Copy link
Owner

Hello @grishavanika,

thanks for asking. Currently, I'm busy with a larger rewrite to transform even more code and to support generic lambdas. I have a private branch where I made some progress with coroutines. As they are now officially part of C++20 things are a bit easier (no additional option is required to activate them).

Examples of coroutines and how the transformed code looks like would help me. In general, I'm not sure how this transformation turns out and if it is helpful at all. However, I plan to approach some people more familiar with coroutines.

All that said, if you like to jump in I can push my development branch or you start something of your own.

Andreas

@Trass3r
Copy link
Author

Trass3r commented May 5, 2019

See #92 (comment)
Sure just push the branch :)

@andreasfertig
Copy link
Owner

Hello @Trass3r,

I know that, thanks. I just like more data. Plus some things are not 100% clear to me. But, I have to check the branch, its been a while since I made changes to it. I will push it and let you know.

Andreas

andreasfertig pushed a commit that referenced this issue May 19, 2019
This is an early (buggy) and incomplete draft of how to visualize
coroutines.
@andreasfertig
Copy link
Owner

Hello all,

I just pushed my draft development branch. The entire branch is more or less just to show what new statements are available and tries to format them.

I'm not clear on:

  • when and how a coroutine is allocated and how to visualize that.
  • how to visualize the suspend and resume

Probably there are more things, but that is what I remember so far. Feel free to contribute.

Andreas

@stale stale bot added the stale No activity label Aug 2, 2019
@andreasfertig andreasfertig removed the stale No activity label Aug 2, 2019
Repository owner deleted a comment from stale bot Aug 2, 2019
@andreasfertig
Copy link
Owner

Hello,

I wrote up a blog post about implementing coroutines in C++ Insights. There are quite some bummers. You can find it here andreasfertig.blog/2019/09/coroutines-in-c-insights.html. In addition to decide what to do I set up a Twitter poll you can take.

Andreas

andreasfertig added a commit that referenced this issue Nov 1, 2019
For more information see docs.cppinsights.io/transformations-coroutines.html.
andreasfertig added a commit that referenced this issue Nov 1, 2019
Fixed #92: Added support to show coroutines as written.
andreasfertig added a commit that referenced this issue Nov 9, 2019
For more information see docs.cppinsights.io/transformations-coroutines.html.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request WIP Work in progress
Projects
None yet
Development

No branches or pull requests

3 participants