Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #404: Unintentional swapping of array dimensions. #445

Merged
merged 1 commit into from
Feb 5, 2022

Conversation

andreasfertig
Copy link
Owner

While this fix addresses the original issue, the construction of an
array as shown is invalid. This could be something resolved by #406.

While this fix addresses the original issue, the construction of an
array as shown is invalid. This could be something resolved by #406.
@codecov
Copy link

codecov bot commented Feb 5, 2022

Codecov Report

Merging #445 (c5f8383) into main (511bb4e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #445   +/-   ##
=======================================
  Coverage   98.62%   98.62%           
=======================================
  Files          23       23           
  Lines        3118     3125    +7     
=======================================
+ Hits         3075     3082    +7     
  Misses         43       43           
Flag Coverage Δ
insights-windows ∅ <ø> (∅)
ubuntu 97.98% <100.00%> (+<0.01%) ⬆️
ubuntu-libcxx 98.08% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
InsightsHelpers.cpp 98.51% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 511bb4e...c5f8383. Read the comment docs.

@andreasfertig andreasfertig merged commit fdf869f into main Feb 5, 2022
@andreasfertig andreasfertig deleted the fixIssue404 branch February 5, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant