Make std::initializer_list visible. #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With C++11 uniform initialization and initializer lists we cannot
longer easily see whether we are calling a normal constructor or one
which takes a initializer_list. For example:
struct V {
V(int x) {}
V(std::initializer_list<int> x) {}
};
V v{1};
V vv{1, 2};
Surprisingly to some people, in both cases the second constructor, taking
a std::initializer_list, is used.
This change shows the difference by putting the name
std::initializer_list<T> in front of an initializer list.
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
==========================================
+ Coverage 95.36% 95.44% +0.08%
==========================================
Files 40 42 +2
Lines 1595 1623 +28
==========================================
+ Hits 1521 1549 +28
Misses 74 74
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With C++11 uniform initialization and initializer lists we cannot
longer easily see whether we are calling a normal constructor or one
which takes a initializer_list. For example:
struct V {
V(int x) {}
V(std::initializer_list x) {}
};
V v{1};
V vv{1, 2};
Surprisingly to some people, in both cases the second constructor, taking
a std::initializer_list, is used.
This change shows the difference by putting the name
std::initializer_list in front of an initializer list.