Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Doctrine Migrations 3.x, support PHP 8.2 and TYPO3 v12 #20

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

andreaswolf
Copy link
Owner

No description provided.

@andreaswolf andreaswolf changed the title Raise requirements Require Doctrine Migrations 3.x, support PHP 8.2 and TYPO3 v12 Aug 6, 2023
* Implement a DependencyFactory for TYPO3
* Get rid of DoctrineService
* Get rid of overwriting the now "final class" *Command from doctrine:migrate
* Wire the dependencies in Services.yaml
* Get rid of obsolete Commands.php
* Add new commands introduced with doctrine/migrations v3:
  - migrations:dump-schema
  - migrations:generate
  - migrations:latest
  - migrations:list
  - migrations:up-to-date

!!! Compatibility Notes:
* `--dry-run` is currently not supported anymore for the "AbstractDataHandlerMigration"
* An upgrade in the doctrine_migrationstatus is required, see README.md
@baschny
Copy link
Contributor

baschny commented Sep 20, 2023

Don't know if you wanted to continue working on it, but it turned up to be more work than expected at first, but it worked. Here is the completion:

#23

Please take a look, maybe we could finish that off and make a release compatible with TYPO3 v11 and v12 soon.

@andreaswolf
Copy link
Owner Author

There seems to be a regression in doctrine/migrations 3.7.1 or 3.7.0, since the pipelines worked with 3.6.0 (in PR #23).

@andreaswolf
Copy link
Owner Author

There seems to be a regression in doctrine/migrations 3.7.1 or 3.7.0, since the pipelines worked with 3.6.0 (in PR #23).

This is due to https://github.com/doctrine/migrations/pull/1363/files, but it seems to be a TYPO3 Core bug, where DateTimeImmutable instances are not correctly processed in Connection::ensureDatabaseValueTypes().

@baschny
Copy link
Contributor

baschny commented Nov 22, 2023

@andreaswolf great that you took over. I will have no time to follow-up on that in the next days, so either you continue to tackle that or I can also take a look at it in a near future.

@andreaswolf
Copy link
Owner Author

There seems to be a regression in doctrine/migrations 3.7.1 or 3.7.0, since the pipelines worked with 3.6.0 (in PR #23).

This is due to https://github.com/doctrine/migrations/pull/1363/files, but it seems to be a TYPO3 Core bug, where DateTimeImmutable instances are not correctly processed in Connection::ensureDatabaseValueTypes().

I opened a bug on TYPO3 Forge: https://forge.typo3.org/issues/102479 and pushed a patch already.

@andreaswolf
Copy link
Owner Author

I opened a bug on TYPO3 Forge: https://forge.typo3.org/issues/102479 and pushed a patch already.

The patch has been released in TYPO3 12.4.9, which should now become the minimum supported 12.x version of this extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants