Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration testing with testcontainers #100

Closed
andregasser opened this issue Jan 16, 2023 · 2 comments · Fixed by #127
Closed

Integration testing with testcontainers #100

andregasser opened this issue Jan 16, 2023 · 2 comments · Fixed by #127
Assignees
Labels
code quality Everything related to code quality
Milestone

Comments

@andregasser
Copy link
Owner

Let's try to create an integration test with testcontainers and a docker-compose setup. I already have the docker-compose part ready. Just need to get started with the testcontainers part.

@andregasser
Copy link
Owner Author

@bocops Yesterday, I realized that the getInstanceVersion call in MastodonClient was failing when used against real Mastodon servers. Root cause was a simple JSON parsing issue that did not popup during mock testing.

In orde to avoid more cases like this after release, I would like to setup a basic integration test suite based on testcontainers, covering the most important functionality of the library. Just to get higher confidence, that everything is working that should work.

Hope to get it done within the next couple of days.

For the 2.0.0 release, I am still confident that we can release it in January though.

@andregasser andregasser added the code quality Everything related to code quality label Jan 18, 2023
@andregasser andregasser self-assigned this Jan 18, 2023
@andregasser andregasser added this to the 2.0.0 milestone Jan 18, 2023
@bocops
Copy link
Collaborator

bocops commented Jan 18, 2023

Quality over speed, any time. I'll find some things to document and refactor in the meantime. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Everything related to code quality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants