Align scope defaults with Mastodon API #116
Assignees
Labels
Milestone
Comments
bocops
added
good first issue
|
Let's fix this in the 2.0.0 then. Already on it. |
bocops
added a commit
to bocops/bigbone
that referenced
this issue
Dec 8, 2023
- makes all scope parameters in OAuth and App methods optional. Endpoints not receiving a scope parameter will default to granting "read" permission. - removes default parameter value from Scope constructor. Users will need to define a certain scope if they want to use it. Closes andregasser#116. - adds all scopes as defined by Mastodon, marks existing scopes FOLLOW and ALL as deprecated. - removes all internal usage of the now deprecated ALL scope. Closes andregasser#143. - moves deduplication of scopes from a separate function into the one building the parameter string. This avoids unnecessarily throwing an IllegalArgumentException. Closes andregasser#381.
PattaFeuFeu
added a commit
that referenced
this issue
Dec 15, 2023
* Update scopes used in OAuth - makes all scope parameters in OAuth and App methods optional. Endpoints not receiving a scope parameter will default to granting "read" permission. - removes default parameter value from Scope constructor. Users will need to define a certain scope if they want to use it. Closes #116. - adds all scopes as defined by Mastodon, marks existing scopes FOLLOW and ALL as deprecated. - removes all internal usage of the now deprecated ALL scope. Closes #143. - moves deduplication of scopes from a separate function into the one building the parameter string. This avoids unnecessarily throwing an IllegalArgumentException. Closes #381. * Enhance Scope usage in tests - in integration tests, declare "full scope" once - in unit tests, do not specify any Scope unless directly tested - remove deprecated "follow" scope from the access token asset * In samples to get access token, ensure that scopes requested for the token match those in OAuth URL. * Enable hierarchical access to defined scopes - replace Name enum with hierarchical structure for a more intuitive access to individual scopes - changing samples and USAGE.md to match Examples: - Scope(Scope.Name.READ) becomes Scope(Scope.READ.ALL) - Scope(Scope.Name.ADMIN_READ_ACCOUNTS) becomes Scope(Scope.ADMIN.READ.ACCOUNTS) --------- Co-authored-by: Patrick Geselbracht <code@patrick-geselbracht.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
AppMethods.createApp()currently defaults to all scopes if none are given. The endpoint that is called defaults to only read scope if none is given: Mastodon documentation.We should default to the same values, and not request more. Breaking change, because our current default value allows more than would be allowed after this change.
Other API methods that send a scope should also be checked.
The text was updated successfully, but these errors were encountered: