Add desktop-fullscreen option and optionally decouple aspect ratio from window resolution. #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…window resolution. Desktop Fullscreen: It was previously possible to run ironwail in desktop fullscreen mode, but only by manually setting a cvar. This change adds the ability to pick this display mode within the video settings menu. Decoupling Aspect Ratio: Previously in ironwail the window/fullscreen size always dictates the aspect ratio tha the game is renderred in. This is fine for windowed and exclusive fullscreen where you can set the specific resolution you want, however with desktop fullscreen, the window must be the same size that your operating system is outputting. Decoupling the aspect ratio allows the user specify a specific maximum aspect ratio to use in this circumstance. For example 4:3 on a standard 16:9 display, or 16:9 on an ultrawide display. The new vid_maxaspect cvar default to 0, which means auto (match window/fullscreen resolution).
Under some configurations where GL_NeedsSceneEffects and GL_NeedsPostprocess return different values the viewport offset was not configured correctly. This change addresses this issue.
KurtLoeffler
changed the title
|
I realize now that the desktop fullscreen feature may not be as important as I originally thought for these reasons:
There are still advantages of the implementation in this pull request though:
If it is preferable to remove the desktop fullscreen part of this pull request and just keep the aspect ratio changes, I can do that. Controlling aspect ratio independently of fullscreen resolution is desirable because on ultrawide monitors the UI stretches out to the edges and becomes hard to see. You can of course use an exclusive fullscreen mode with a specific resolution at the aspect ratio you desire, but this comes a lot of problems like slow alt+tabbing and possibly messing up other application window positions and sizes in Windows. |
andrei-drexler
force-pushed
the
master
branch
22 times, most recently
from
e78c96b
to
42850da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces two improvements to the Video Options menu of Ironwail:
Desktop Fullscreen Option:
Decoupling Aspect Ratio from Window Resolution:
vid_maxaspect, has been added, with a default value of 0 (auto, match window/fullscreen aspect ratio).