New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
option to turn off "always translate" for a domain (from latest update) #9
Comments
yes please |
Hello, I encounter the same issue. Once translated one time, all pages of a domain are translated, even when a i don't want it. The option to turn off "always translate" don't work. The old behaviour (translating only when I ask for it) was far better. Thanks |
Damn! I had no clue the old behavior was desirable for some people :D I will implement it the next time I get to work on it. I would like to keep domain translation as default. How do you prefer the feature?
|
try this extension, maybe it will work until I fix this issue https://github.com/jeremiahlee/page-translator |
I think the option 4 would be the best. |
I was also thinking about 4 but wanted to see other opinions. |
I like 2 in addition to 4. Better yet, if the option could be turned off/on by domain. |
Here is the new beta with this feature. Please test https://github.com/andreicristianpetcu/google_translate_this/releases/tag/v2.3.1 |
The option page works ! On Firefox ESR for Windows at least. Thanks. Having options for default behaviour is pretty useful. |
Thanks for considering this change! I just wanted to chime in that the reason I liked the old way is so that I can translate a page with foreign text that might not necessarily be in another language. For example: a Youtube video with a lot of international people commenting in different language, or the comment section on a Facebook page with different languages. |
Did you try the beta @jcosentino ? https://github.com/andreicristianpetcu/google_translate_this/releases/tag/v2.3.1 I need to test it a bit more until I ship it as an update. |
I have. So far, it seems to work with the new option of translating only once. However, with that option enabled, it still says "Always translate [website]" even though it does not, as intended. |
I'll release a fix next week for this. Thank you for testing @jcosentino |
Thanks.
The text was updated successfully, but these errors were encountered: