Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

h72 schematics usability #31

Closed
rusefillc opened this issue Apr 21, 2021 · 4 comments
Closed

h72 schematics usability #31

rusefillc opened this issue Apr 21, 2021 · 4 comments
Assignees
@andreika-git

Comments

@rusefillc
Copy link
Collaborator

image

That's very confusing.

Do we have two different "in_knock" here - module internal "in_knock" pad and h72 frame "in_knock" net?

If those are in fact two different entities having same name I would suggest to change the naming convention to avoid the confusion. I like the "raw" for inputs from connector, maybe "mcu_knock" for all nets between MCU and modules?
@andreika-git
Copy link
Owner

IMHO this should belong to https://github.com/rusefi/hellen72/issues/

@rusefillc
Copy link
Collaborator Author

I bet that's a hellen-one pattern not an issue specific to any board

andreika-git pushed a commit to rusefi/hellen-miata-NB2 that referenced this issue Apr 23, 2021
rev.D first attempt + intelligible schematics refactoring andreika-gi…
1613bde 
…t/hellen-one#31
@andreika-git
Copy link
Owner

image

@rusefillc
Copy link
Collaborator Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreika-git andreika-git

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andreika-git @rusefillc