Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mission #125 #103

Open
mitramartin opened this issue Jul 17, 2017 · 5 comments
Open

mission #125 #103

mitramartin opened this issue Jul 17, 2017 · 5 comments

Comments

@mitramartin
Copy link
Collaborator

hi @andreimoment, i am trying to add Mission 125 into the Cocreation Labs curriculum but it doesn't show up: http://tangomanual.com/org/cocreationlabs/curriculum/#/

help? mitra

@mitramartin
Copy link
Collaborator Author

happily i was able to create a new organization and new curriculum !

@andreimoment
Copy link
Owner

@mitramartin, did two things to make the mission appear in the list:

  • removed the square brackets from the end of the "layout:" line in the mission (see the diff: 053adea)
  • add the mission name to the mission names list in _data/mission_names.yml (I will remove the need to maintain such a list with some additional coding. And apologies, if I forgot to mention its existence to you. Here's the diff: 8ab2c68 )

Important question: Why mission number 125 and not number 56?

The original intention was to have all missions as numbers in a sequence so that there's never doubt about which number is next. Jumping from 55 to 125 goes against this logic. Would you consider having this new mission as the next number in the sequence instead and rename the file to 56.md?

@mitramartin
Copy link
Collaborator Author

thanks, got it @andreimoment

yes i will change to 56

@mitramartin
Copy link
Collaborator Author

okay i did this and changed to 56 and now also doesn't seem to appear? http://tangomanual.com/org/cocreationlabs/curriculum/#/

@andreimoment
Copy link
Owner

It the missions names file had the mission name under 125 and not under 56. I updated it and so now the mission shows in the list.

I also renamed 57 to 57.md and added its name to the same mission names list so that it is available for inclusion in curriculums.

Again, I will work on a way to automatically deduce the mission names instead of keeping a list manually.

Look at this link to see what I changed (ignore the Gemfile part):
512c2b1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants