Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add README.md with GIF describing steps to import an example notebook… #35

Merged
merged 1 commit into from
Jun 23, 2024

Conversation

cosminc98
Copy link
Collaborator

… in Kaggle from GitHub

@cosminc98 cosminc98 closed this Jun 8, 2024
@cosminc98
Copy link
Collaborator Author

Closing for now as GIF is not showing (possibly due to size limitations).

@cosminc98 cosminc98 reopened this Jun 10, 2024
@cosminc98
Copy link
Collaborator Author

It seems that there is a 5MB size limit for GIFs to be shown in GitHub. Anyway, it works now.
@andreinechaev what's your opinion on hosting the static content of this repository? There is this one GIF and a bunch of images from the notebooks and I'm currently hosting them in an S3 bucket (but if something were to happen to me, the data would be lost). I don't like uploading images/gifs to repositories due to forcing everyone to download them when they are not needed to run the code locally, but I guess we have a package deployed so the main use case (installing from pypi) wouldn't be affected by hosting them here. Alternatively we could set up a separate GitHub repository to keep this one clean. Let me know what you think.

@andreinechaev
Copy link
Owner

It seems that there is a 5MB size limit for GIFs to be shown in GitHub. Anyway, it works now. @andreinechaev what's your opinion on hosting the static content of this repository? There is this one GIF and a bunch of images from the notebooks and I'm currently hosting them in an S3 bucket (but if something were to happen to me, the data would be lost). I don't like uploading images/gifs to repositories due to forcing everyone to download them when they are not needed to run the code locally, but I guess we have a package deployed so the main use case (installing from pypi) wouldn't be affected by hosting them here. Alternatively we could set up a separate GitHub repository to keep this one clean. Let me know what you think.

I don't see a problem with hosting it here. As you pointed out, the PyPI itself isn't affected.

@cosminc98 cosminc98 merged commit 801584c into master Jun 23, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants