updated argsSize parameter to match exact size of calldata #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated argsSize parameter in staticall() and call() for exactly passing the exact calldata size and to avoid mistakenly copying any other mem slots
|
Closing this, as I've found more things to be modified when running the example code and I've pushed a new commit myself that also fixes this, but your idea was right. Thank you for getting it into my attention! |
No Issues, thanks for addressing it and making the required changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated argsSize parameter in staticall() and call() for exactly passing the exact calldata size and to avoid mistakenly copying any other mem slots